[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368432#comment-14368432 ]
Sean Busbey commented on HBASE-13273: ------------------------------------- turns out it doesn't prevent it, because Result doesn't implement equals/hashCode. If we do an equality test in copyFrom, we should still use reference equality so it's clear that what we mean is _exactly_ the EMPTY_RESULT instance. > Make Result.EMPTY_RESULT read-only; currently it can be modified > ---------------------------------------------------------------- > > Key: HBASE-13273 > URL: https://issues.apache.org/jira/browse/HBASE-13273 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0, 1.0.0 > Reporter: stack > Assignee: Mikhail Antonov > Labels: beginner > Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 > > Attachments: HBASE-13273.patch, HBASE-13273.patch > > > Again from [~larsgeorge] > Result result2 = Result.EMPTY_RESULT; > System.out.println(result2); > result2.copyFrom(result1); > System.out.println(result2); > "What do you think happens when result1 has cells? Yep, you just modified the > shared public EMPTY_RESULT to be not empty anymore." > Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)