[
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370659#comment-14370659
]
Josh Elser commented on HBASE-13262:
------------------------------------
[~tedyu] no dice with that patch. Still bails out early. It exhibits the same
symptoms as previously, but I didn't dig further.
{noformat}
2015-03-19 23:34:44,269 INFO [main] hbase.HBaseTest(184): Saw 198352 rows
2015-03-19 23:34:44,269 INFO [main] hbase.HBaseTest(185): Saw 1983520 cells
{noformat}
[~jonathan.lawlor], thanks again for the confirmation on my findings!
{quote}
Notice that when withTags is false, we end up stripping those 2 bytes! The
question now is why does 0.98 NOT have this problem. The implementation of
ScannerV3#getCellBuffSize hasn't changed from 0.98 to branch-1.0 – does that
mean that in 0.98 we end up using ScannerV2#getCellBuffSize instead of V3...
(I'm not too familiar with this area myself so maybe someone can confirm/deny)?
{quote}
Is there a reason to even do the following change of the length when there are
no tags? It would result in slightly more data sent to the client, but is there
a compatibility (or any other) reason too?
{code}
if (!withTags) {
length = kv.getKeyLength() + kv.getValueLength() +
KEYVALUE_INFRASTRUCTURE_SIZE;
}
{code}
[~lhofhansl], thanks for throwing up a patch for 0.98. It makes sense to me.
Anyone mind if I try to take a stab at adding the necessary changes to the RPC
layer to push this extra logic into (as we've talked about a couple of times
now)? Lars, you mentioned, trunk, would we also want to target any branch1
stuff with this?
> ResultScanner doesn't return all rows in Scan
> ---------------------------------------------
>
> Key: HBASE-13262
> URL: https://issues.apache.org/jira/browse/HBASE-13262
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 2.0.0, 1.1.0
> Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Blocker
> Fix For: 2.0.0, 1.1.0, 0.98.13
>
> Attachments: 13262-0.98-testpatch.txt,
> 13262-tag-length-for-withTags-parameter.txt, regionserver-logging.diff,
> testrun_0.98.txt, testrun_branch1.0.txt
>
>
> Tried to write a simple Java client again 1.1.0-SNAPSHOT.
> * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]),
> for a total of 10M cells written
> * Read back the data from the table, ensure I saw 10M cells
> Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of
> the actual rows. Running against 1.0.0, returns all 10M records as expected.
> [Code I was
> running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
> for the curious.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
