[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385196#comment-14385196 ]
Lars George commented on HBASE-10728: ------------------------------------- Let's restart this issue, it cannot be that this is broken for a year now. There are two issues here I see: * {{get_counter}} needing an unnecessary last {{value}} parameter. We can make it accept {{nil}} but if it is never used, why keep it? * {{incr}} does not return the current value anymore, though it receives the {{Result}} instance for every call. [~jmspaggi], you mentioned this being a wider issue. What else is wrong? > get_counter value is never used. > -------------------------------- > > Key: HBASE-10728 > URL: https://issues.apache.org/jira/browse/HBASE-10728 > Project: HBase > Issue Type: Bug > Affects Versions: 0.96.2, 0.98.1, 0.99.0 > Reporter: Jean-Marc Spaggiari > Assignee: Jean-Marc Spaggiari > Attachments: HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, > HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, > HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, > HBASE-10728-v2-trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)