[ https://issues.apache.org/jira/browse/HBASE-13375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395276#comment-14395276 ]
Srikanth Srungarapu commented on HBASE-13375: --------------------------------------------- Do you think groups can be null (checked code but doesn't look like it)? And also, can remoteUgi be null? {code} + String[] groups = remoteUgi.getGroupNames(); + if (groups != null && groups.length > 0) { {code} Is it worth to create a local variable for {{getSystemAndSuperUsers()}}? {code} + List<String> superUsers = + VisibilityUtils.getSystemAndSuperUsers(rpcServices.getConfiguration()).getFirst(); + List<String> superGroups = + VisibilityUtils.getSystemAndSuperUsers(rpcServices.getConfiguration()).getSecond(); {code} > Provide HBase superuser higher priority over other users in the RPC handling > ---------------------------------------------------------------------------- > > Key: HBASE-13375 > URL: https://issues.apache.org/jira/browse/HBASE-13375 > Project: HBase > Issue Type: Improvement > Components: rpc > Reporter: Devaraj Das > Assignee: Mikhail Antonov > Fix For: 1.1.0 > > Attachments: HBASE-13375-v0.patch > > > HBASE-13351 annotates Master RPCs so that RegionServer RPCs are treated with > a higher priority compared to user RPCs (and they are handled by a separate > set of handlers, etc.). It may be good to stretch this to users too - hbase > superuser (configured via hbase.superuser) gets higher priority over other > users in the RPC handling. That way the superuser can always perform > administrative operations on the cluster even if all the normal priority > handlers are occupied (for example, we had a situation where all the master's > handlers were tied up with many simultaneous createTable RPC calls from > multiple users and the master wasn't able to perform any operations initiated > by the admin). (Discussed this some with [~enis] and [~elserj]). > Does this make sense to others? -- This message was sent by Atlassian JIRA (v6.3.4#6332)