[ https://issues.apache.org/jira/browse/HBASE-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486641#comment-14486641 ]
Anoop Sam John commented on HBASE-10619: ---------------------------------------- Thanks for the reviews Jerry and Srikanth. Regarding if else comment. As the if conditions are breaking the path of execution in the method (it throws Exception and come out) I thought we no need to have else block as such.. You said it wrt better readability with if else? If so I tend to agree.. Better readability would be with if else.. If so I can change on commit. > Don't allow non super users to do DDL ops on system tables > ---------------------------------------------------------- > > Key: HBASE-10619 > URL: https://issues.apache.org/jira/browse/HBASE-10619 > Project: HBase > Issue Type: Bug > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Attachments: HBASE-10619.patch, HBASE-10619_V2.patch, > HBASE-10619_V3.patch, HBASE-10619_V4.patch, HBASE-10619_V5.patch, > HBASE-10619_V6.patch > > > Don't allow non super users to do DDL ops on system tables > For META and NS tables, we should allow them to be disabled even by super > users. With out these tables online the cluster will be non operational. -- This message was sent by Atlassian JIRA (v6.3.4#6332)