[
https://issues.apache.org/jira/browse/HBASE-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-13307:
--------------------------
Resolution: Fixed
Release Note: Made methods smaller under Scanner#next so inlinable and
compilable (was getting 'too big to compile' from hotspot). Use of unsafe to
parse shorts rather than use BB#getShort... faster, etc.
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Pushed to master branch too.
Thanks for reviews A&R.
> Making methods under ScannerV2#next inlineable, faster
> ------------------------------------------------------
>
> Key: HBASE-13307
> URL: https://issues.apache.org/jira/browse/HBASE-13307
> Project: HBase
> Issue Type: Sub-task
> Components: Scanners
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0, 1.1.0
>
> Attachments: 13307.txt, 13307v2.branch-1.txt, 13307v3.branch-1.txt,
> 13307v4.branch-1.txt, 13307v5.branch-1.txt, 13307v6.branch-1.txt,
> 13307v6.txt, 13307v7.txt, cpu.png, gc.png, next.png, traces.8.svg,
> traces.9.svg
>
>
> See parent issue for patch and evidence.
> I was looking at graphs of our scan and found that methods were 'too big' to
> be inlined (looking at jvm compilation and inlining output flags -- see
> parent for list). Changing method size helped some. Let me commit the
> resultant patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
