[ 
https://issues.apache.org/jira/browse/HBASE-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118980#comment-13118980
 ] 

jirapos...@reviews.apache.org commented on HBASE-4520:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2143/
-----------------------------------------------------------

Review request for hbase, Michael Stack and Jonathan Gray.


Summary
-------

Modify StoreFile to make it clear where Bloom filter type settings come from. 
We have two sources of truth: (1) HFile; and (2) CF configuration. (1) takes 
precedence in the reader, and (2) takes precedence in the writer.


This addresses bug HBASE-4520.
    https://issues.apache.org/jira/browse/HBASE-4520


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java fa629c7 

Diff: https://reviews.apache.org/r/2143/diff


Testing
-------

Running unit tests. I will post the results here -- please don't commit this 
yet.


Thanks,

Mikhail


                
> Better handling of Bloom filter type discrepancy between HFile and CF config
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-4520
>                 URL: https://issues.apache.org/jira/browse/HBASE-4520
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>            Priority: Minor
>             Fix For: 0.94.0
>
>
> Modify StoreFile to make it clear where Bloom filter type settings come from. 
> We have two sources of truth: (1) HFile; and (2) CF configuration. (1) takes 
> precedence in the reader, and (2) takes precedence in the writer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to