[ https://issues.apache.org/jira/browse/HBASE-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6480: ---------------------------------- Resolution: Not A Problem Status: Resolved (was: Patch Available) > If callQueueSize exceed maxQueueSize, all call will be rejected, do not > reject priorityCall > -------------------------------------------------------------------------------------------- > > Key: HBASE-6480 > URL: https://issues.apache.org/jira/browse/HBASE-6480 > Project: HBase > Issue Type: Improvement > Reporter: binlijin > Attachments: HBASE-6480-94.patch, HBASE-6480-trunk.patch > > > Current if the callQueueSize exceed maxQueueSize, all call will be rejected, > Should we let the priority Call pass through? > Current: > {code} > if ((callSize + callQueueSize.get()) > maxQueueSize) { > Call callTooBig = xxx > return ; > } > if (priorityCallQueue != null && getQosLevel(param) > highPriorityLevel) { > priorityCallQueue.put(call); > updateCallQueueLenMetrics(priorityCallQueue); > } else { > callQueue.put(call); // queue the call; maybe blocked here > updateCallQueueLenMetrics(callQueue); > } > {code} > Should we change it to : > {code} > if (priorityCallQueue != null && getQosLevel(param) > highPriorityLevel) { > priorityCallQueue.put(call); > updateCallQueueLenMetrics(priorityCallQueue); > } else { > if ((callSize + callQueueSize.get()) > maxQueueSize) { > Call callTooBig = xxx > return ; > } > callQueue.put(call); // queue the call; maybe blocked here > updateCallQueueLenMetrics(callQueue); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)