[
https://issues.apache.org/jira/browse/HBASE-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505895#comment-14505895
]
Andrew Purtell commented on HBASE-13496:
----------------------------------------
Why are you not using JMH? I am inclined not to believe your results until you
employ a well known rigorous microbenchmark framework to get stable results.
JMH will help you/us avoid all of the common and almost unavoidable pitfalls
one faces when trying to microbenchmark on a highly dynamic optimizing platform.
> Make Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo inlineable
> -----------------------------------------------------------------------------
>
> Key: HBASE-13496
> URL: https://issues.apache.org/jira/browse/HBASE-13496
> Project: HBase
> Issue Type: Sub-task
> Components: Scanners
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 2.0.0, 1.2.0
>
> Attachments: ByteBufferUtils.java, HBASE-13496.patch,
> OffheapVsOnHeapCompareTest.java
>
>
> While testing with some other perf comparisons I have noticed that the above
> method (which is very hot in read path) is not getting inline
> bq.@ 16
> org.apache.hadoop.hbase.util.Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo
> (364 bytes) hot method too big
> We can do minor refactoring to make it inlineable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
