[ 
https://issues.apache.org/jira/browse/HBASE-13552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Lawlor updated HBASE-13552:
------------------------------------
    Attachment: HBASE-13552.patch

Hope it's okay if I take this one, caught my eye because of my earlier work in 
this area. Here's a simple patch that adds a toString to ScheduledChore and 
uses scheduled chores in the log message rather than the runnables returned 
from shutdown. 

Example of new output format:

{noformat}
Chore service for: testShutdownCancelsScheduledChores had [[ScheduledChore: 
Name: sc2 Period: 100 Unit: MILLISECONDS], [ScheduledChore: Name: sc3 Period: 
100 Unit: MILLISECONDS], [ScheduledChore: Name: sc1 Period: 100 Unit: 
MILLISECONDS]] on shutdown
{noformat}

> ChoreService shutdown message could be more informative
> -------------------------------------------------------
>
>                 Key: HBASE-13552
>                 URL: https://issues.apache.org/jira/browse/HBASE-13552
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Andrew Purtell
>            Priority: Trivial
>         Attachments: HBASE-13552.patch
>
>
> {noformat}
> 2015-04-23 18:34:38,163 INFO  [M:0;localhost:43244] hbase.ChoreService: Chore 
> service for: localhost,43244,1429833734975 had 
> [java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@420579b4,
>  
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@75793a48,
>  
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@69e18938,
>  
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@55f7f1d6,
>  
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@92644b2, 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@2f6806cf,
>  
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@56971859,
>  
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@59bfa778]
>  on shutdown
> {noformat}
> Let's give those tasks human meaningful names. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to