[
https://issues.apache.org/jira/browse/HBASE-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513541#comment-14513541
]
Srikanth Srungarapu commented on HBASE-13568:
---------------------------------------------
Second draft for fixing the checkstyle and javadoc errors. I left out the
following checkstyle error.
{code}
while (!(eval = predicate.evaluate())
&& (remainderWait = mustEnd - System.currentTimeMillis()) > 0) {
//
}
{code}
Checkstyle is not liking the inner assignment..I can fix this by changing this
to the following.
{code}
eval = predicate.evaluate();
remainderWait = mustEnd - System.currentTimeMillis();
while(!eval && remainderWait > 0) {
//
eval = predicate.evaluate();
remainderWait = mustEnd - System.currentTimeMillis();
}
{code}
But first version looks more appealing. Thoughts?
> Make Waiter class a public API.
> -------------------------------
>
> Key: HBASE-13568
> URL: https://issues.apache.org/jira/browse/HBASE-13568
> Project: HBase
> Issue Type: Task
> Reporter: Srikanth Srungarapu
> Assignee: Srikanth Srungarapu
> Priority: Minor
> Attachments: HBASE-13568.patch, HBASE-13568_v2.patch
>
>
> During ProcV2 code reviews, it is suggested that Waiter class is useful
> enough to make it a public API. This change decomposes the existing Waiter
> class into two classes, one for public use and the other exclusively for the
> internal testing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
