[ 
https://issues.apache.org/jira/browse/HBASE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120692#comment-13120692
 ] 

Jonathan Gray commented on HBASE-4422:
--------------------------------------

I have looked at 3446 more.  I'm happy with it and confident it makes things 
better.  Will give the +1.

Re: getting the cache instance from CacheConf, i'm open to other designs, but 
this seems best in that we only need one argument for all the caching stuff vs. 
a separate reference for the cache itself.  What did you have in mind?

Maybe CacheConfig + BlockCache should be somehow combined?  Dunno.
                
> Move block cache parameters and references into single CacheConf class
> ----------------------------------------------------------------------
>
>                 Key: HBASE-4422
>                 URL: https://issues.apache.org/jira/browse/HBASE-4422
>             Project: HBase
>          Issue Type: Improvement
>          Components: io
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.92.0
>
>         Attachments: CacheConfig92-v8.patch
>
>
> From StoreFile down to HFile, we currently use a boolean argument for each of 
> the various block cache configuration parameters that exist.  The number of 
> parameters is going to continue to increase as we look at compressed cache, 
> delta encoding, and more specific L1/L2 configuration.  Every new config 
> currently requires changing many constructors because it introduces a new 
> boolean.
> We should move everything into a single class so that modifications are much 
> less disruptive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to