[ 
https://issues.apache.org/jira/browse/HBASE-13576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527645#comment-14527645
 ] 

Hadoop QA commented on HBASE-13576:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12730290/HBASE-13576.v3-master.patch
  against master branch at commit 2ee5f8f5fd834be20273829962e694dbd50ccc97.
  ATTACHMENT ID: 12730290

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13936//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13936//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13936//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13936//console

This message is automatically generated.

> HBCK enhancement: Failure in checking one region should not fail the entire 
> HBCK operation.
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13576
>                 URL: https://issues.apache.org/jira/browse/HBASE-13576
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 2.0.0, 1.1.0, 1.2.0
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>         Attachments: HBASE-13576.v1-master.patch, 
> HBASE-13576.v2-master.patch, HBASE-13576.v3-master.patch
>
>
> HBaseFsck#checkRegionConsistency() checks region consistency and repair the 
> corruption if requested.  However, this function expects some exceptions.  
> For example, in one aspect of region repair, it calls 
> HBaseFsckRepair#waitUntilAssigned(), if a region is in transition for over 
> 120 seconds (default value of "hbase.hbck.assign.timeout" configuration), 
> IOException would throw.
> The problem is that one exception in checkRegionConsistency() would kill 
> entire hbck operation, because the exception would propagate up.
> The proposal is that if the region is not META region ( or a system table 
> region if we prefer),  we can skip the region if  
> HBaseFsck#checkRegionConsistency() fails.  We could print out skip regions in 
> summary section so that users know to either re-run or investigate potential 
> issue for that region. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to