[ 
https://issues.apache.org/jira/browse/HBASE-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529938#comment-14529938
 ] 

Ashish Singhi commented on HBASE-13562:
---------------------------------------

Thanks Srikanth for reviewing the patch.
bq. I noticed some new tests like testTableModify getting added to 
TestNamespaceCommands. We already have them in TestAccessController, isn't it?
Yes we do have but that does not cover namespace related permission checks.

> Expand AC testing coverage to include all combinations of scope and 
> permissions.
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-13562
>                 URL: https://issues.apache.org/jira/browse/HBASE-13562
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Srikanth Srungarapu
>            Assignee: Ashish Singhi
>         Attachments: HBASE-13562.patch
>
>
> As of now, the tests in TestAccessController and TestAccessController2 
> doesn't cover all the combinations of Scope and Permissions. Ideally, we 
> should have testing coverage for the entire [ACL 
> matrix|https://hbase.apache.org/book/appendix_acl_matrix.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to