[ 
https://issues.apache.org/jira/browse/HBASE-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537111#comment-14537111
 ] 

Hadoop QA commented on HBASE-13562:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12731788/HBASE-13562_v2.patch
  against master branch at commit 5a2ca43fa16a95d8db67e5a3d8b48e4d3f3a9aeb.
  ATTACHMENT ID: 12731788

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 27 new 
or modified tests.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to 
fail with Hadoop version 2.4.1.

    Compilation errors resume:
    [ERROR] COMPILATION ERROR : 
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:[169,8]
 org.apache.hadoop.hbase.master.HMaster is not abstract and does not override 
abstract method 
modifyTable(org.apache.hadoop.hbase.TableName,org.apache.hadoop.hbase.HTableDescriptor)
 in org.apache.hadoop.hbase.master.MasterServices
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:[1787,15]
 
modifyTable(org.apache.hadoop.hbase.TableName,org.apache.hadoop.hbase.HTableDescriptor)
 in org.apache.hadoop.hbase.master.HMaster cannot implement 
modifyTable(org.apache.hadoop.hbase.TableName,org.apache.hadoop.hbase.HTableDescriptor)
 in org.apache.hadoop.hbase.master.MasterServices
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:[1786,3]
 method does not override or implement a method from a supertype
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java:[301,17]
 
modifyTable(org.apache.hadoop.hbase.TableName,org.apache.hadoop.hbase.HTableDescriptor)
 in org.apache.hadoop.hbase.master.HMaster cannot implement 
modifyTable(org.apache.hadoop.hbase.TableName,org.apache.hadoop.hbase.HTableDescriptor)
 in org.apache.hadoop.hbase.master.MasterServices
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on 
project hbase-server: Compilation failure: Compilation failure:
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:[169,8]
 org.apache.hadoop.hbase.master.HMaster is not abstract and does not override 
abstract method 
modifyTable(org.apache.hadoop.hbase.TableName,org.apache.hadoop.hbase.HTableDescriptor)
 in org.apache.hadoop.hbase.master.MasterServices
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:[1787,15]
 
modifyTable(org.apache.hadoop.hbase.TableName,org.apache.hadoop.hbase.HTableDescriptor)
 in org.apache.hadoop.hbase.master.HMaster cannot implement 
modifyTable(org.apache.hadoop.hbase.TableName,org.apache.hadoop.hbase.HTableDescriptor)
 in org.apache.hadoop.hbase.master.MasterServices
[ERROR] return type void is not compatible with long
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:[1786,3]
 method does not override or implement a method from a supertype
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java:[301,17]
 
modifyTable(org.apache.hadoop.hbase.TableName,org.apache.hadoop.hbase.HTableDescriptor)
 in org.apache.hadoop.hbase.master.HMaster cannot implement 
modifyTable(org.apache.hadoop.hbase.TableName,org.apache.hadoop.hbase.HTableDescriptor)
 in org.apache.hadoop.hbase.master.MasterServices
[ERROR] return type void is not compatible with long
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :hbase-server
    

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13997//console

This message is automatically generated.

> Expand AC testing coverage to include all combinations of scope and 
> permissions.
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-13562
>                 URL: https://issues.apache.org/jira/browse/HBASE-13562
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Srikanth Srungarapu
>            Assignee: Ashish Singhi
>         Attachments: HBASE-13562-v1.patch, HBASE-13562-v2.patch, 
> HBASE-13562.patch, HBASE-13562_v2.patch, sample.patch
>
>
> As of now, the tests in TestAccessController and TestAccessController2 
> doesn't cover all the combinations of Scope and Permissions. Ideally, we 
> should have testing coverage for the entire [ACL 
> matrix|https://hbase.apache.org/book/appendix_acl_matrix.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to