[ https://issues.apache.org/jira/browse/HBASE-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121610#comment-13121610 ]
Todd Lipcon commented on HBASE-4402: ------------------------------------ Your fix looks good. I didn't think about the fact that there might be nulls due to regions that were added while the server was offline, or if a table was disabled when shutdown, but ZK was wiped before the cluster was brought back up. > Retaining locality after restart broken > --------------------------------------- > > Key: HBASE-4402 > URL: https://issues.apache.org/jira/browse/HBASE-4402 > Project: HBase > Issue Type: Bug > Components: master > Affects Versions: 0.92.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Blocker > Fix For: 0.92.0 > > Attachments: hbase-4402.txt, hbase-4402.txt > > > In DefaultLoadBalancer, we implement the "retain assignment" function like so: > {code} > if (sn != null && servers.contains(sn)) { > assignments.get(sn).add(region.getKey()); > {code} > but this will never work since after a cluster restart, all servers have a > new ServerName with a new startcode. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira