[
https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121710#comment-13121710
]
[email protected] commented on HBASE-4482:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/
-----------------------------------------------------------
(Updated 2011-10-06 04:20:33.696931)
Review request for hbase.
Changes
-------
v4 of the diff. Got rid of the whole putIfAbsent/onEviction loops. Replaced
with synchronize and thread.sleep/wait.
Summary
-------
Bugfix, kills a race condition.
Ignore r1, thats the wrong patch.
This addresses bug HBASE-4482.
https://issues.apache.org/jira/browse/HBASE-4482
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
3798a06
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java
91b1603
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3840279
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 4072387
src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java
e021780
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java
8dd5159
Diff: https://reviews.apache.org/r/2051/diff
Testing
-------
Looped tests.
Thanks,
Li
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira