[ 
https://issues.apache.org/jira/browse/HBASE-13675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547571#comment-14547571
 ] 

Hadoop QA commented on HBASE-13675:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12733432/HBASE-13675.patch
  against master branch at commit f49111e5f8a2db8f3065188f03c7ad6d4411bd10.
  ATTACHMENT ID: 12733432

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14072//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14072//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14072//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14072//console

This message is automatically generated.

> ProcedureExecutor completion report should be at DEBUG log level
> ----------------------------------------------------------------
>
>                 Key: HBASE-13675
>                 URL: https://issues.apache.org/jira/browse/HBASE-13675
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0, 1.1.0
>            Reporter: Andrew Purtell
>            Assignee: Srikanth Srungarapu
>            Priority: Minor
>         Attachments: HBASE-13675.patch
>
>
> Example:
> {noformat}
> 2015-05-12 12:05:03,445 INFO  [ProcedureExecutorThread-0] 
> procedure2.ProcedureExecutor: Procedure completed in 838msec: 
> EnableTableProcedure (table=cluster_test) user=apurtell (auth:SIMPLE) id=5 
> state=FINISHED
> {noformat}
> The procedures themselves are already emitting task specific information at 
> INFO level. This doesn't add much information besides the elapsed time, so 
> probably should be at DEBUG level. I assume if a procedure fails there will 
> be additional logging at WARN level, but if not, that could be a 
> consideration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to