[ 
https://issues.apache.org/jira/browse/HBASE-13616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550070#comment-14550070
 ] 

Hadoop QA commented on HBASE-13616:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12733724/13616.wip.v5.branch-1.1.txt
  against branch-1.1 branch at commit 5e7e626ef54ada9e75b18b31bb49e23b22ae9fe9.
  ATTACHMENT ID: 12733724

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 24 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +            regionsOnCrashedServer_ = 
java.util.Collections.unmodifiableList(regionsOnCrashedServer_);
+              new java.lang.String[] { "UserInfo", "UnmodifiedTableSchema", 
"ModifiedTableSchema", "DeleteColumnFamilyInModify", });
+              new java.lang.String[] { "ServerName", "DistributedLogReplay", 
"RegionsOnCrashedServer", "RegionsToAssign", "CarryingMeta", "CarryingSystem", 
"ShouldSplitWal", });
+      ServerCrashProcedure procedure = new 
ServerCrashProcedure(SERVERNAME_DEAD, true, false, false);
+    ZKAssign.transitionNode(this.watcher, REGIONINFO, SERVERNAME_DEAD, 
EventType.M_ZK_REGION_OFFLINE,
+    
Mockito.when(this.serverManager.sendRegionOpen(Mockito.eq(SERVERNAME_LIVE), 
Mockito.eq(REGIONINFO),

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14084//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14084//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14084//artifact/patchprocess/checkstyle-aggregate.html

  Javadoc warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14084//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14084//console

This message is automatically generated.

> Move ServerShutdownHandler to Pv2
> ---------------------------------
>
>                 Key: HBASE-13616
>                 URL: https://issues.apache.org/jira/browse/HBASE-13616
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>    Affects Versions: 1.1.0
>            Reporter: stack
>            Assignee: stack
>         Attachments: 13616.wip.txt, 13616.wip.v3.branch-1.txt, 
> 13616.wip.v4.branch-1.txt, 13616.wip.v5.branch-1.1.txt, 13616wip.v2.txt
>
>
> Move ServerShutdownHandler to run on ProcedureV2. Need this for DLR to work. 
> See HBASE-13567.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to