[
https://issues.apache.org/jira/browse/HBASE-13733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554716#comment-14554716
]
Stephen Yuan Jiang commented on HBASE-13733:
--------------------------------------------
Run all 6 test suites in my local machine against master branch - all of them
pass without issue. I will re-attach the patch to try one more time.
> failed MiniZooKeeperCluster startup not shut down ZK servers
> ------------------------------------------------------------
>
> Key: HBASE-13733
> URL: https://issues.apache.org/jira/browse/HBASE-13733
> Project: HBase
> Issue Type: Bug
> Components: Zookeeper
> Affects Versions: 2.0.0, 1.1.0, 1.2.0
> Reporter: Stephen Yuan Jiang
> Assignee: Stephen Yuan Jiang
> Fix For: 2.0.0, 1.2.0, 1.1.1
>
> Attachments: HBASE-13733.patch
>
>
> MiniZooKeeperCluster#startup() starts servers one-by-one, if everything is
> good, it would declare success of start:
> {code}
> public int startup(File baseDir, int numZooKeeperServers)
> ...
> // running all the ZK servers
> for (int i = 0; i < numZooKeeperServers; i++) {
> ...===> could throw exception in the loop and end the startup
> // Start up this ZK server
> standaloneServerFactory.startup(server);
> ...
> standaloneServerFactoryList.add(standaloneServerFactory);
> zooKeeperServers.add(server);
> }
> ...
> started = true;
> ...
> }
> {code}
> However, if exception throws in the middle of start up (eg. some servers
> already started), the MiniZooKeeperCluster#shutdown() would not shut down
> them and clean up resources.
> {code}
> public void shutdown() throws IOException {
> if (!started) {
> return;
> }
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
