[
https://issues.apache.org/jira/browse/HBASE-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555659#comment-14555659
]
Hudson commented on HBASE-13703:
--------------------------------
FAILURE: Integrated in HBase-1.2 #98 (See
[https://builds.apache.org/job/HBase-1.2/98/])
HBASE-13703 ReplicateContext should not be a member of ReplicationSource.
(larsh: rev e5df9bb2e2303d3b182ba80ee31e7fa155aa29fc)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
> ReplicateContext should not be a member of ReplicationSource
> ------------------------------------------------------------
>
> Key: HBASE-13703
> URL: https://issues.apache.org/jira/browse/HBASE-13703
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 2.0.0, 0.98.13, 1.0.2, 1.1.1
>
> Attachments: 13703.txt
>
>
> The ReplicateContext object is created once per ReplicationSource and then
> reused when we have something to ship to the sinks.
> This is a misguided optimization. ReplicateContext is very lightweight
> (definitely compared to the all the work and copying the ReplicationSource is
> doing) and, crucially, it prevent the the entries array from being collected
> after it was successfully copied to the sink, wasting potentially a lot of
> heap.
> The entries array itself holds reference to WAL entries on the heap, that now
> also cannot be collected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
