[ 
https://issues.apache.org/jira/browse/HBASE-13376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559855#comment-14559855
 ] 

Ted Yu commented on HBASE-13376:
--------------------------------

{code}
800             LOG.debug("Lowest locality region server with non zero regions 
is "
801                 + servers[lowestLocalServerIndex].getHostname());
{code}
Include the locality in the above message.
{code}
806         int getLowestLocalRegionOnServer(int serverIndex) {
{code}
Rename the method as getLowestLocalityRegionOnServer
{code}
841             int lowestLoadedServerIndex = -1;
{code}
Rename variable leastLoadedServerIndex

> Improvements to Stochastic load balancer
> ----------------------------------------
>
>                 Key: HBASE-13376
>                 URL: https://issues.apache.org/jira/browse/HBASE-13376
>             Project: HBase
>          Issue Type: Improvement
>          Components: Balancer
>    Affects Versions: 1.0.0, 0.98.12
>            Reporter: Vandana Ayyalasomayajula
>            Assignee: Vandana Ayyalasomayajula
>            Priority: Minor
>         Attachments: HBASE-13376_0.98.txt, HBASE-13376_0.txt, 
> HBASE-13376_1.txt, HBASE-13376_98.patch
>
>
> There are two things this jira tries to address:
> 1. The locality picker in the stochastic balancer does not pick regions with 
> least locality as candidates for swap/move. So when any user configures 
> locality cost in the configs, the balancer does not always seems to move 
> regions with bad locality. 
> 2. When a cluster has equal number of loaded regions, it always picks the 
> first one. It should pick a random region on one of the equally loaded 
> servers. This improves a chance of finding a good candidate, when load picker 
> is invoked several times. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to