[ https://issues.apache.org/jira/browse/HBASE-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572048#comment-14572048 ]
Hadoop QA commented on HBASE-13827: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12737428/HBASE-13827.patch against master branch at commit e8e5a9f6398f5a99f1d89be359212a7a4f1d7b05. ATTACHMENT ID: 12737428 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14274//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14274//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14274//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14274//console This message is automatically generated. > Delayed scanner close in KeyValueHeap and StoreScanner > ------------------------------------------------------ > > Key: HBASE-13827 > URL: https://issues.apache.org/jira/browse/HBASE-13827 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-13827.patch, HBASE-13827.patch > > > This is to support the work in HBASE-12295. We have to return the blocks when > the close() happens on the HFileScanner. Right now close is not at all > there. Will add. The StoreFileScanner will call it on its close(). > In KVHeap when we see one of the child scanner runs out of cells, we will > remove them from the PriorityQueue as well as close it. Also the same kind of > stuff in StoreScanner too. But when we want to do the return block in close() > this kind of early close is not correct. Still there might be cells created > out of these cached blocks. > This Jira aims at changing these container scanners not to do early close. > When it seems a child scanner no longer required, it will avoid using it > completely but just wont call close(). Instead it will be added to another > list for a delayed close and that will be closed when the container scanner > close() happens. -- This message was sent by Atlassian JIRA (v6.3.4#6332)