[ https://issues.apache.org/jira/browse/HBASE-13755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573520#comment-14573520 ]
Mikhail Antonov commented on HBASE-13755: ----------------------------------------- Thanks for taking a look! bq. As long as we can throw Exception when used before initialize(Conf) it is fine Could you elaborate? We're throwing {code} if (superUsers == null || superGroups == null) { throw new IOException("Super users/super groups lists haven't been initialized properly,"); } {code} If lists haven't been initialized properly? I'll address other comments in next version of patch - thanks for review. Will make it Private - my oversight. Regarding the naming - I can't come up with a better name either :( so I'd say - unless someone jumps in and suggest better name, let's commit as Superusers, as long as it's Private it should be no problem to open a new renaming jira as soon as someone finds better name :) > Provide single super user check implementation > ---------------------------------------------- > > Key: HBASE-13755 > URL: https://issues.apache.org/jira/browse/HBASE-13755 > Project: HBase > Issue Type: Improvement > Reporter: Anoop Sam John > Assignee: Mikhail Antonov > Fix For: 2.0.0, 1.2.0 > > Attachments: HBASE-13755-v1.patch > > > Followup for HBASE-13375. -- This message was sent by Atlassian JIRA (v6.3.4#6332)