[ https://issues.apache.org/jira/browse/HBASE-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574336#comment-14574336 ]
Hadoop QA commented on HBASE-13828: ----------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12737876/HBASE-13828-v1.patch against master branch at commit 67c463f63e3c48efd9e1281166b707a3a806a2ad. ATTACHMENT ID: 12737876 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 12 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14300//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14300//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14300//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14300//console This message is automatically generated. > Add group permissions testing coverage to AC. > --------------------------------------------- > > Key: HBASE-13828 > URL: https://issues.apache.org/jira/browse/HBASE-13828 > Project: HBase > Issue Type: Improvement > Reporter: Srikanth Srungarapu > Assignee: Ashish Singhi > Attachments: HBASE-13828-0.98.patch, HBASE-13828-branch-1.0.patch, > HBASE-13828-branch-1.1.patch, HBASE-13828-branch-1.patch, > HBASE-13828-v1.patch, HBASE-13828.patch > > > We suffered a regression HBASE-13826 recently due to lack of testing coverage > for group permissions for AC. With the recent perf boost provided by > HBASE-13658, it wouldn't be a bad idea to add checks for group level users to > applicable unit tests in TestAccessController. -- This message was sent by Atlassian JIRA (v6.3.4#6332)