[ https://issues.apache.org/jira/browse/HBASE-13959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600668#comment-14600668 ]
Hadoop QA commented on HBASE-13959: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12741781/HBASE-13959-2.patch against master branch at commit 2df3236a4eee48bf723213a7c4ff3d29c832c8cf. ATTACHMENT ID: 12741781 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14561//console This message is automatically generated. > Region splitting takes too long because it uses a single thread in most > common cases > ------------------------------------------------------------------------------------ > > Key: HBASE-13959 > URL: https://issues.apache.org/jira/browse/HBASE-13959 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 0.98.12 > Reporter: Hari Krishna Dara > Assignee: Hari Krishna Dara > Fix For: 0.98.14 > > Attachments: HBASE-13959-2.patch, HBASE-13959.patch > > > When storefiles need to be split as part of a region split, the current logic > uses a threadpool with the size set to the size of the number of stores. > Since most common table setup involves only a single column family, this > translates to having a single store and so the threadpool is run with a > single thread. However, in a write heavy workload, there could be several > tens of storefiles in a store at the time of splitting, and with a threadpool > size of one, these files end up getting split sequentially. > With a bit of tracing, I noticed that it takes on an average of 350ms to > create a single reference file, and splitting each storefile involves > creating two of these, so with a storefile count of 20, it takes about 14s > just to get through this phase alone (2 reference files for each storefile), > pushing the total time the region is offline to 18s or more. For environments > that are setup to fail fast, this makes the client exhaust all retries and > fail with NotServingRegionException. > The fix should increase the concurrency of this operation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)