[ 
https://issues.apache.org/jira/browse/HBASE-13963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602208#comment-14602208
 ] 

Hadoop QA commented on HBASE-13963:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12741966/HBASE-13963.2.patch
  against master branch at commit b5b5853043e20a719f1b7afb485ede68ddd823f0.
  ATTACHMENT ID: 12741966

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+0 tests included{color}.  The patch appears to be a 
documentation patch that doesn't require tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestImportExport
                  org.apache.hadoop.hbase.util.TestProcessBasedCluster

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14580//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14580//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14580//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14580//console

This message is automatically generated.

> avoid leaking jdk.tools
> -----------------------
>
>                 Key: HBASE-13963
>                 URL: https://issues.apache.org/jira/browse/HBASE-13963
>             Project: HBase
>          Issue Type: Sub-task
>          Components: build, documentation
>            Reporter: Sean Busbey
>            Assignee: Gabor Liptak
>            Priority: Critical
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-13963.1.patch, HBASE-13963.2.patch
>
>
> Right now hbase-annotations uses jdk7 jdk.tools and exposes that to 
> downstream via hbase-client. We need it for building and using our custom 
> doclet, but can improve a couple of things: 
> -1) We should be using a jdk.tools version based on our java version (use jdk 
> activated profiles to set it)-
> 2) We should not be including any jdk.tools version in our hbase-client 
> transitive dependencies (or other downstream-facing artifacts). 
> Unfortunately, system dependencies are included in transitive resolution, so 
> we'll need to exclude it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to