[
https://issues.apache.org/jira/browse/HBASE-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127058#comment-13127058
]
jirapos...@reviews.apache.org commented on HBASE-4568:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2385/
-----------------------------------------------------------
(Updated 2011-10-13 22:33:54.109200)
Review request for hbase, Dhruba Borthakur, Michael Stack, Jonathan Gray,
Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan
Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.
Changes
-------
Remove trailing space.
Summary
-------
1) For each zk dump, currently hbase will create a zk client instance every
time.
This is quite slow when any machines in the quorum is dead. Because it will
connect to each machine in the zk quorum again.
<code>
HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
Configuration conf = master.getConfiguration();
HBaseAdmin hbadmin = new HBaseAdmin(conf);
HConnection connection = hbadmin.getConnection();
ZooKeeperWatcher watcher = connection.getZooKeeperWatcher();
</code>
So we can simplify this:
<code>
HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
ZooKeeperWatcher watcher = master.getZooKeeperWatcher();
</code>
2) Also when hbase call getServerStats() for each machine in the zk quorum, it
hard coded the default time out as 1 min.
It would be nice to make this configurable and set it to a low time out.
When hbase tries to connect to each machine in the zk quorum, it will create
the socket, and then set the socket time out, and read it with this time out.
It means hbase will create a socket and connect to the zk server with 0 time
out at first, which will take a long time.
Because a timeout of zero is interpreted as an infinite timeout. The connection
will then block until established or an error occurs.
3) The recoverable zookeeper should be real exponentially backoff when there is
connection loss exception, which will give hbase much longer time window to
recover from zk machine failures.
This addresses bug HBASE-4568.
https://issues.apache.org/jira/browse/HBASE-4568
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java 61ea552
src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java
b8c4f61
src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 699a5f5
src/main/resources/hbase-webapps/master/zk.jsp b31d94c
Diff: https://reviews.apache.org/r/2385/diff
Testing
-------
Running all the unit tests
Thanks,
Liyin
> Make zk dump jsp response more quickly
> --------------------------------------
>
> Key: HBASE-4568
> URL: https://issues.apache.org/jira/browse/HBASE-4568
> Project: HBase
> Issue Type: Improvement
> Reporter: Liyin Tang
> Assignee: Liyin Tang
>
> For each zk dump, currently hbase will create a zk client instance every
> time.
> This is quite slow when any machines in the quorum is dead. Because it will
> connect to each machine in the zk quorum again.
> HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
> Configuration conf = master.getConfiguration();
> HBaseAdmin hbadmin = new HBaseAdmin(conf);
> HConnection connection = hbadmin.getConnection();
> ZooKeeperWatcher watcher = connection.getZooKeeperWatcher();
> So we can simplify this:
> HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
> ZooKeeperWatcher watcher = master.getZooKeeperWatcher();
> Also when hbase call getServerStats() for each machine in the zk quorum, it
> hard coded the default time out as 1 min.
> It would be nice to make this configurable and set it to a low time out.
> When hbase tries to connect to each machine in the zk quorum, it will create
> the socket, and then set the socket time out, and read it with this time out.
> It means hbase will create a socket and connect to the zk server with 0 time
> out at first, which will take a long time.
> Because a timeout of zero is interpreted as an infinite timeout. The
> connection will then block until established or an error occurs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
