[ https://issues.apache.org/jira/browse/HBASE-13989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606402#comment-14606402 ]
Hadoop QA commented on HBASE-13989: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12742557/13989-v2.txt against master branch at commit 3eee7302847b55291cc87820d96e603f5e4d7612. ATTACHMENT ID: 12742557 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn post-site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14605//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14605//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14605//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14605//console This message is automatically generated. > Threshold for combined MemStore and BlockCache percentages is not checked > ------------------------------------------------------------------------- > > Key: HBASE-13989 > URL: https://issues.apache.org/jira/browse/HBASE-13989 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Attachments: 13989-v1.txt, 13989-v2.txt > > > In HeapMemoryManager#doInit(): > {code} > globalMemStorePercentMinRange = conf.getFloat(MEMSTORE_SIZE_MIN_RANGE_KEY, > globalMemStorePercent); > globalMemStorePercentMaxRange = conf.getFloat(MEMSTORE_SIZE_MAX_RANGE_KEY, > globalMemStorePercent); > ... > if (globalMemStorePercent == globalMemStorePercentMinRange > && globalMemStorePercent == globalMemStorePercentMaxRange) { > return false; > } > {code} > If memory tuning is not specified, globalMemStorePercentMinRange and > globalMemStorePercentMaxRange would carry the value of globalMemStorePercent. > This would make doInit() exit before checking the threshold for combined > MemStore and BlockCache percentages. -- This message was sent by Atlassian JIRA (v6.3.4#6332)