[ https://issues.apache.org/jira/browse/HBASE-13387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618294#comment-14618294 ]
Anoop Sam John commented on HBASE-13387: ---------------------------------------- bq.-1 javac. The applied patch generated 20 javac compiler warnings (more than the master's current 16 warnings). Because of more ref to Unsafe. bq.-1 javadoc. The javadoc tool appears to have generated 1 warning messages. New ref to sun.unsafe package in ByteBufferUtils.java. Have to add to OK_COUNT bq.-1 checkstyle. The applied patch generated 1899 checkstyle errors (more than the master's current 1898 errors). An unused import in the patch. Can correct these on commit. Will commit tonight my time > Add ByteBufferedCell an extension to Cell > ----------------------------------------- > > Key: HBASE-13387 > URL: https://issues.apache.org/jira/browse/HBASE-13387 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: ByteBufferedCell.docx, HBASE-13387_v1.patch, > HBASE-13387_v2.patch, WIP_HBASE-13387_V2.patch, WIP_ServerCell.patch, > benchmark.zip > > > This came in btw the discussion abt the parent Jira and recently Stack added > as a comment on the E2E patch on the parent Jira. > The idea is to add a new Interface 'ByteBufferedCell' in which we can add > new buffer based getter APIs and getters for position in components in BB. > We will keep this interface @InterfaceAudience.Private. When the Cell is > backed by a DBB, we can create an Object implementing this new interface. > The Comparators has to be aware abt this new Cell extension and has to use > the BB based APIs rather than getXXXArray(). Also give util APIs in CellUtil > to abstract the checks for new Cell type. (Like matchingXXX APIs, > getValueAs<type> APIs etc) -- This message was sent by Atlassian JIRA (v6.3.4#6332)