[ https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-14099: ------------------------------------------- Attachment: storefile.png HBASE-14099_1.patch Just refactored it as suggested. Also the KVUtil.createLastOnRow was creating a KV with LATEST_TIMESTAMP. It should be OLDEST_TIMESTAMP. Also attaching a screen shot of a profiler that shows this KV creation that happens by copying the byte[] before the patch. We reduce two object creations including its copy. Thanks for the review. > StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start > and stop Row > --------------------------------------------------------------------------------------- > > Key: HBASE-14099 > URL: https://issues.apache.org/jira/browse/HBASE-14099 > Project: HBase > Issue Type: Bug > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14099.patch, HBASE-14099_1.patch, storefile.png > > > During profiling saw that the code here in passesKeyRangeFilter in Storefile > {code} > KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil > .createFirstOnRow(scan.getStopRow()) : > KeyValueUtil.createFirstOnRow(scan > .getStartRow()); > KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil > .createLastOnRow(scan.getStartRow()) : > KeyValueUtil.createLastOnRow(scan > .getStopRow()); > {code} > This row need not be copied now considering that we have > CellComparator.compareRows(Cell, byte[]). > We have already refactored the firstKeyKv and lastKeyKV as part of other > JIRAs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)