[ https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-14099: ------------------------------------------- Attachment: HBASE-14099_4.patch bq.-1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestFastFail The failure is random I think. Corrected the javadoc too. Will commit this patch now. > StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start > and stop Row > --------------------------------------------------------------------------------------- > > Key: HBASE-14099 > URL: https://issues.apache.org/jira/browse/HBASE-14099 > Project: HBase > Issue Type: Improvement > Components: Performance, Scanners > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-14099.patch, HBASE-14099_1.patch, > HBASE-14099_2.patch, HBASE-14099_3.patch, HBASE-14099_4.patch, storefile.png > > > During profiling saw that the code here in passesKeyRangeFilter in Storefile > {code} > KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil > .createFirstOnRow(scan.getStopRow()) : > KeyValueUtil.createFirstOnRow(scan > .getStartRow()); > KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil > .createLastOnRow(scan.getStartRow()) : > KeyValueUtil.createLastOnRow(scan > .getStopRow()); > {code} > This row need not be copied now considering that we have > CellComparator.compareRows(Cell, byte[]). > We have already refactored the firstKeyKv and lastKeyKV as part of other > JIRAs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)