[ 
https://issues.apache.org/jira/browse/HBASE-14078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634490#comment-14634490
 ] 

Hadoop QA commented on HBASE-14078:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12746248/hbase-14708-v1.patch
  against master branch at commit 7ce318dd3be9df0ee1c025b4792ded0161aa2c9c.
  ATTACHMENT ID: 12746248

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):       
at 
org.apache.hadoop.hbase.TestChoreService.testForceTrigger(TestChoreService.java:398)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14848//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14848//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14848//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14848//console

This message is automatically generated.

> improve error message when HMaster can't bind to port
> -----------------------------------------------------
>
>                 Key: HBASE-14078
>                 URL: https://issues.apache.org/jira/browse/HBASE-14078
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>              Labels: beginner
>             Fix For: 2.0.0
>
>         Attachments: hbase-14708-v1.patch
>
>
> When the master fails to start becahse hbase.master.port is already taken, 
> the log messages could make it easier to tell.
> {quote}
> 2015-07-14 13:10:02,667 INFO  [main] regionserver.RSRpcServices: 
> master/master01.example.com/10.20.188.121:16000 server-side HConnection 
> retries=350
> 2015-07-14 13:10:02,879 INFO  [main] ipc.SimpleRpcScheduler: Using deadline 
> as user call queue, count=3
> 2015-07-14 13:10:02,895 ERROR [main] master.HMasterCommandLine: Master exiting
> java.lang.RuntimeException: Failed construction of Master: class 
> org.apache.hadoop.hbase.master.HMaster
>         at 
> org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:2258)
>         at 
> org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:234)
>         at 
> org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:140)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>         at 
> org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:126)
>         at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:2272)
> Caused by: java.net.BindException: Address already in use
>         at sun.nio.ch.Net.bind0(Native Method)
>         at sun.nio.ch.Net.bind(Net.java:444)
>         at sun.nio.ch.Net.bind(Net.java:436)
>         at 
> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:214)
>         at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>         at org.apache.hadoop.hbase.ipc.RpcServer.bind(RpcServer.java:2513)
>         at 
> org.apache.hadoop.hbase.ipc.RpcServer$Listener.<init>(RpcServer.java:599)
>         at org.apache.hadoop.hbase.ipc.RpcServer.<init>(RpcServer.java:2000)
>         at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.<init>(RSRpcServices.java:919)
>         at 
> org.apache.hadoop.hbase.master.MasterRpcServices.<init>(MasterRpcServices.java:211)
>         at 
> org.apache.hadoop.hbase.master.HMaster.createRpcServices(HMaster.java:509)
>         at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.<init>(HRegionServer.java:535)
>         at org.apache.hadoop.hbase.master.HMaster.<init>(HMaster.java:351)
>         at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
>         at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
>         at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>         at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
>         at 
> org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:2253)
>         ... 5 more
> {quote}
> I recognize that the "RSRpcServices" log message shows port 16000, but I 
> don't know why a new operator would. Additionally, it'd be nice to tell them 
> that the port is controlled by {{hbase.master.port}}. Maybe give a hint on 
> how to see what's using the port. Could be too os-dist specific?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to