[
https://issues.apache.org/jira/browse/HBASE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129340#comment-13129340
]
jirapos...@reviews.apache.org commented on HBASE-4607:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2411/#review2635
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
<https://reviews.apache.org/r/2411/#comment5940>
If exitWorker is false, we would enter taskLoop at line 167.
Is this desirable ?
- Ted
On 2011-10-17 22:41:49, Mikhail Bautin wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2411/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-17 22:41:49)
bq.
bq.
bq. Review request for hbase and Prakash Khemani.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is an attempt to fix the fact that SplitLogWorker threads are not
being terminated properly in some unit tests. This probably does not happen in
production because the master always creates the log-splitting ZK node, but it
does happen in 89-fb. Thanks to Prakash Khemani for help on this.
bq.
bq.
bq. This addresses bug hbase-4607.
bq. https://issues.apache.org/jira/browse/hbase-4607
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
a43e0b3
bq.
bq. Diff: https://reviews.apache.org/r/2411/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. I will run unit tests and post an update when they have passed.
bq.
bq.
bq. Thanks,
bq.
bq. Mikhail
bq.
bq.
> Split log worker should terminate properly when waiting for znode
> -----------------------------------------------------------------
>
> Key: HBASE-4607
> URL: https://issues.apache.org/jira/browse/HBASE-4607
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
>
> This is an attempt to fix the fact that SplitLogWorker threads are not being
> terminated properly in some unit tests. This probably does not happen in
> production because the master always creates the log-splitting ZK node, but
> it does happen in 89-fb. Thanks to Prakash Khemani for help on this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
