[
https://issues.apache.org/jira/browse/HBASE-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643288#comment-14643288
]
Hadoop QA commented on HBASE-14157:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12747379/14157-v1.txt
against master branch at commit 3f80e0ea4f101298d9dbd574ffcf388afb621d55.
ATTACHMENT ID: 12747379
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14898//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14898//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14898//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14898//console
This message is automatically generated.
> Interfaces implemented by subclasses should be checked when registering
> CoprocessorService
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-14157
> URL: https://issues.apache.org/jira/browse/HBASE-14157
> Project: HBase
> Issue Type: Bug
> Reporter: Alok Lal
> Assignee: Ted Yu
> Attachments: 14157-v1.txt, 14157-v2.txt
>
>
> Alok reported seeing the following exception when subclass of class which
> implements CoprocessorService is used for hbase.coprocessor.region.classes :
> {code}
> hbase(main):015:0> grant 'mktg1', 'RWC', 'iemployee'
> ERROR: org.apache.hadoop.hbase.exceptions.UnknownProtocolException: No
> registered coprocessor service found for name AccessControlService in region
> hbase:acl,,1437137157604.2daf735ea38da95e9ba249db6b63b79c.
> at
> org.apache.hadoop.hbase.regionserver.HRegion.execService(HRegion.java:7367)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.execServiceOnRegion(RSRpcServices.java:1873)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.execService(RSRpcServices.java:1855)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:32209)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2112)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:101)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
> {code}
> The root cause is in the following code of RegionCoprocessorHost:
> {code}
> for (Class<?> c : implClass.getInterfaces()) {
> if (CoprocessorService.class.isAssignableFrom(c)) {
> region.registerService( ((CoprocessorService)instance).getService() );
> }
> }
> {code}
> We currently only check the interfaces directly implemented by the underlying
> class.
> What should be done is to check all the interfaces implemented by class
> itself and its superclasses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
