[
https://issues.apache.org/jira/browse/HBASE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129461#comment-13129461
]
jirapos...@reviews.apache.org commented on HBASE-4580:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2420/
-----------------------------------------------------------
(Updated 2011-10-18 03:50:10.732314)
Review request for hbase.
Changes
-------
I have modified by Ted's review.
TestMasterFailover passed.
-------------------------------------------------------
T E S T S
-------------------------------------------------------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.master.TestMasterFailover
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 126.414 sec
Summary
-------
https://issues.apache.org/jira/browse/HBASE-4580
This addresses bug HBASE-4580.
https://issues.apache.org/jira/browse/HBASE-4580
Diffs (updated)
-----
/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1185442
Diff: https://reviews.apache.org/r/2420/diff
Testing
-------
1. I tested it in real cluster(3 nodes, created a table with 15 regions).
a)restart the cluster.
b)kill master and then start master
c)kill master and one region server, then start master.
2. all the UT test cased passed.(I tested twice)
Results :
Tests in error:
testBadOriginalRootLocation(org.apache.hadoop.hbase.catalog.TestCatalogTrackerOnCluster):
unknown host: example.org
Tests run: 1031, Failures: 0, Errors: 1, Skipped: 16
The TestCatalogTrackerOnCluster passed in a connected network environment.
T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.catalog.TestCatalogTrackerOnCluster
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.502 sec
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
Thanks,
jinchao
> Some invalid zk nodes were created when a clean cluster restarts
> ----------------------------------------------------------------
>
> Key: HBASE-4580
> URL: https://issues.apache.org/jira/browse/HBASE-4580
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.92.0
> Reporter: gaojinchao
> Assignee: gaojinchao
> Fix For: 0.92.0
>
> Attachments: HBASE-4580_TrunkV1.patch
>
>
> The below logs said that we created a invalid zk node when restarted a
> cluster.
> it mistakenly believed that the regions belong to a dead server.
> 2011-10-11 05:05:29,127 INFO org.apache.hadoop.hbase.master.HMaster: Meta
> updated status = true
> 2011-10-11 05:05:29,127 INFO org.apache.hadoop.hbase.master.HMaster:
> ROOT/Meta already up-to date with new HRI.
> 2011-10-11 05:05:29,151 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Creating (or updating) unassigned node for
> 771d63e9327383159553619a4f2dc74f with OFFLINE state
> 2011-10-11 05:05:29,161 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Creating (or updating) unassigned node for
> 3cf860dd323fe6360f571aeafc129f95 with OFFLINE state
> 2011-10-11 05:05:29,170 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Creating (or updating) unassigned node for
> 4065350214452a9d5c55243c734bef08 with OFFLINE state
> 2011-10-11 05:05:29,178 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Creating (or updating) unassigned node for
> 4e81613f82a39fc6e5e89f96e7b3ccc4 with OFFLINE state
> 2011-10-11 05:05:29,187 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Creating (or updating) unassigned node for
> e21b9e1545a28953aba0098fda5c9cd9 with OFFLINE state
> 2011-10-11 05:05:29,195 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Creating (or updating) unassigned node for
> 5cd9f55eecd43d088bbd505f6795131f with OFFLINE state
> 2011-10-11 05:05:29,229 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Creating (or updating) unassigned node for
> db5f641452a70b09b85a92970e4198c7 with OFFLINE state
> 2011-10-11 05:05:29,237 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Creating (or updating) unassigned node for
> a7b20a653919e7f41bfb2ed349af7d21 with OFFLINE state
> 2011-10-11 05:05:29,253 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Creating (or updating) unassigned node for
> c9385619425f737eab1a6624d2e097a8 with OFFLINE state
> // we cleaned all zk nodes.
> 2011-10-11 05:05:29,262 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Clean cluster startup.
> Assigning userregions
> 2011-10-11 05:05:29,262 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Deleting any existing unassigned nodes
> 2011-10-11 05:05:29,367 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 9 region(s)
> across 1 server(s), retainAssignment=true
> 2011-10-11 05:05:29,369 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Timeout-on-RIT=9000
> 2011-10-11 05:05:29,369 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 9 region(s)
> to C3S3,54366,1318323920153
> 2011-10-11 05:05:29,369 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning done
> 2011-10-11 05:05:29,371 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Async create of unassigned node for
> 771d63e9327383159553619a4f2dc74f with OFFLINE state
> 2011-10-11 05:05:29,371 INFO org.apache.hadoop.hbase.master.HMaster: Master
> has completed initialization
> 2011-10-11 05:05:29,371 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Async create of unassigned node for
> 3cf860dd323fe6360f571aeafc129f95 with OFFLINE state
> 2011-10-11 05:05:29,371 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Async create of unassigned node for
> 4065350214452a9d5c55243c734bef08 with OFFLINE state
> 2011-10-11 05:05:29,371 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Async create of unassigned node for
> 4e81613f82a39fc6e5e89f96e7b3ccc4 with OFFLINE state
> 2011-10-11 05:05:29,371 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Async create of unassigned node for
> e21b9e1545a28953aba0098fda5c9cd9 with OFFLINE state
> 2011-10-11 05:05:29,372 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Async create of unassigned node for
> 5cd9f55eecd43d088bbd505f6795131f with OFFLINE state
> 2011-10-11 05:05:29,372 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Async create of unassigned node for
> db5f641452a70b09b85a92970e4198c7 with OFFLINE state
> 2011-10-11 05:05:29,372 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Async create of unassigned node for
> a7b20a653919e7f41bfb2ed349af7d21 with OFFLINE state
> 2011-10-11 05:05:29,372 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> master:58198-0x132f23a9a380000 Async create of unassigned node for
> c9385619425f737eab1a6624d2e097a8 with OFFLINE state
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
