[ https://issues.apache.org/jira/browse/HBASE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130887#comment-13130887 ]
Hudson commented on HBASE-3581: ------------------------------- Integrated in HBase-TRUNK #2340 (See [https://builds.apache.org/job/HBase-TRUNK/2340/]) HBASE-4620 I broke the build when I submitted HBASE-3581 (Send length of the rpc response) stack : Files : * /hbase/trunk/CHANGES.txt * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/ResponseFlag.java > hbase rpc should send size of response > -------------------------------------- > > Key: HBASE-3581 > URL: https://issues.apache.org/jira/browse/HBASE-3581 > Project: HBase > Issue Type: Improvement > Reporter: ryan rawson > Assignee: stack > Priority: Critical > Fix For: 0.92.0 > > Attachments: 3581-v2.txt, 3581-v3.txt, 3581-v4.txt, > HBASE-rpc-response.txt > > > The RPC reply from Server->Client does not include the size of the payload, > it is framed like so: > <i32> callId > <byte> errorFlag > <byte[]> data > The data segment would contain enough info about how big the response is so > that it could be decoded by a writable reader. > This makes it difficult to write buffering clients, who might read the entire > 'data' then pass it to a decoder. While less memory efficient, if you want to > easily write block read clients (eg: nio) it would be necessary to send the > size along so that the client could snarf into a local buf. > The new proposal is: > <i32> callId > <i32> size > <byte> errorFlag > <byte[]> data > the size being sizeof(data) + sizeof(errorFlag). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira