[ https://issues.apache.org/jira/browse/HBASE-14202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682409#comment-14682409 ]
Hudson commented on HBASE-14202: -------------------------------- FAILURE: Integrated in HBase-TRUNK #6714 (See [https://builds.apache.org/job/HBase-TRUNK/6714/]) HBASE-14202 Reduce garbage we create. (anoopsamjohn: rev d49b1f60f4cec6f04768f28f678bf4329bfa7364) * hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java * hbase-common/src/main/java/org/apache/hadoop/hbase/nio/ByteBuff.java * hbase-common/src/main/java/org/apache/hadoop/hbase/nio/MultiByteBuff.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/ByteBufferIOEngine.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/IOEngine.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/ObjectIntPair.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestByteBufferIOEngine.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/FastDiffDeltaEncoder.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DiffKeyDeltaEncoder.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestFileIOEngine.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestBufferedDataBlockEncoder.java * hbase-common/src/main/java/org/apache/hadoop/hbase/nio/SingleByteBuff.java * hbase-common/src/test/java/org/apache/hadoop/hbase/nio/TestMultiByteBuff.java > Reduce garbage we create > ------------------------ > > Key: HBASE-14202 > URL: https://issues.apache.org/jira/browse/HBASE-14202 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners > Affects Versions: 2.0.0 > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-14202.patch > > > 2 optimizations wrt no# short living objects we create > 1. IOEngine#read call to read from L2 cache is always creating a Pair object > to return the BB and MemoryType. We can avoid this by making the read API to > return a Cacheable. Pass the CacheableDeserializer, to be used, also to the > read API. Setter for MemoryType is already there in Cacheable interface. > 2. ByteBuff#asSubByteBuffer(int, int, Pair) avoids Pair object creation > every time as we pass the shared Pair object. Still as pair can take only > Objects, the primitive int has to be boxed into an Integer object every time. > This can be avoided by creating a new Pair type which is a pair of an Object > and a primitive int. -- This message was sent by Atlassian JIRA (v6.3.4#6332)