[ 
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131086#comment-13131086
 ] 

Lars Hofhansl commented on HBASE-4626:
--------------------------------------

Exactly!

There are a bunch subclasses of WritableByteArrayComparable to deal with, so I 
refactored some code slightly.

The only funky thing is the NullComparator. All other comparators would fail 
with an NPE if a null byte[] is passed (even before my change); so for this one 
comparator I have the compareTo(byte[],int,int[]) method throw an 
unsupportedOperationException.

I have a patch. Running tests now.
                
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
>                 Key: HBASE-4626
>                 URL: https://issues.apache.org/jira/browse/HBASE-4626
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>
> Just looked at SingleCol and ValueFilter... And on every column compared they 
> create a copy of the column and/or value portion of the KV.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to