[ 
https://issues.apache.org/jira/browse/HBASE-13376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693911#comment-14693911
 ] 

Vandana Ayyalasomayajula commented on HBASE-13376:
--------------------------------------------------

In the last build, the balancer tests passed.
https://builds.apache.org/job/PreCommit-HBASE-Build/15053//consoleFull
{quote}
Running org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.982 sec - in 
org.apache.hadoop.hbase.master.TestAssignmentListener
Running org.apache.hadoop.hbase.master.TestMasterMetricsWrapper
Running org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.229 sec - in 
org.apache.hadoop.hbase.master.TestMasterMetricsWrapper
Running org.apache.hadoop.hbase.master.balancer.TestBaseLoadBalancer
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.58 sec - in 
org.apache.hadoop.hbase.master.balancer.TestBaseLoadBalancer
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 51.025 sec - in 
org.apache.hadoop.hbase.master.handler.TestTableDescriptorModification
Running org.apache.hadoop.hbase.master.balancer.TestDefaultLoadBalancer
{quote}

The one that failed was :
{quote}
Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 22.187 sec <<< 
FAILURE! - in 
org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
testWalRollOnLowReplication(org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS)
  Time elapsed: 11.906 sec  <<< ERROR!
java.lang.RuntimeException: sync aborted
        at 
org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.pushData(WALProcedureStore.java:491)
        at 
org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.insert(WALProcedureStore.java:334)
        at 
org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS.testWalRollOnLowReplication(TestWALProcedureStoreOnHDFS.java:190)
Caused by: org.apache.hadoop.ipc.RemoteException: File 
/test-logs/state-00000000000000000008.log could only be replicated to 2 nodes 
instead of minReplication (=3).  There are 3 datanode(s) running and 3 node(s) 
are excluded in this operation.
        at 
org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.chooseTarget(BlockManager.java:1471)
        at 
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(FSNamesystem.java:2791)
        at 
org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addBlock(NameNodeRpcServer.java:606)
        at 
org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.addBlock(ClientNamenodeProtocolServerSideTranslatorPB.java:455)
        at 
org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
        at 
org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:585)
        at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:928)
        at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2013)
        at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2009)
        at java.security.AccessController.doPrivileged(Native Method)
        at javax.security.auth.Subject.doAs(Subject.java:415)
        at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1614)
        at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2007)

        at org.apache.hadoop.ipc.Client.call(Client.java:1411)
        at org.apache.hadoop.ipc.Client.call(Client.java:1364)
        at 
org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:206)
        at com.sun.proxy.$Proxy20.addBlock(Unknown Source)
        at sun.reflect.GeneratedMethodAccessor8.invoke(Unknown Source)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at 
org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:187)
        at 
org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:102)
        at com.sun.proxy.$Proxy20.addBlock(Unknown Source)
        at 
org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.addBlock(ClientNamenodeProtocolTranslatorPB.java:368)
        at 
org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.locateFollowingBlock(DFSOutputStream.java:1449)
        at 
org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.nextBlockOutputStream(DFSOutputStream.java:1270)
        at 
org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.run(DFSOutputStream.java:526)
{quote}

> Improvements to Stochastic load balancer
> ----------------------------------------
>
>                 Key: HBASE-13376
>                 URL: https://issues.apache.org/jira/browse/HBASE-13376
>             Project: HBase
>          Issue Type: Improvement
>          Components: Balancer
>    Affects Versions: 1.0.0, 0.98.12
>            Reporter: Vandana Ayyalasomayajula
>            Assignee: Vandana Ayyalasomayajula
>            Priority: Minor
>         Attachments: 13376-v2.txt, HBASE-13376.patch, HBASE-13376_0.98.txt, 
> HBASE-13376_0.txt, HBASE-13376_1.txt, HBASE-13376_1_1.txt, 
> HBASE-13376_2.patch, HBASE-13376_2_branch-1.patch, HBASE-13376_3.patch, 
> HBASE-13376_3.patch, HBASE-13376_98.patch, HBASE-13376_branch-1.patch
>
>
> There are two things this jira tries to address:
> 1. The locality picker in the stochastic balancer does not pick regions with 
> least locality as candidates for swap/move. So when any user configures 
> locality cost in the configs, the balancer does not always seems to move 
> regions with bad locality. 
> 2. When a cluster has equal number of loaded regions, it always picks the 
> first one. It should pick a random region on one of the equally loaded 
> servers. This improves a chance of finding a good candidate, when load picker 
> is invoked several times. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to