[ https://issues.apache.org/jira/browse/HBASE-14222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696727#comment-14696727 ]
Hadoop QA commented on HBASE-14222: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12750463/HBASE-14222.patch against master branch at commit 4dd30ab019cfbf3691fd08f7941d33d8bbc37f05. ATTACHMENT ID: 12750463 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1 warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn post-site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.TestIOFencing org.apache.hadoop.hbase.master.TestDistributedLogSplitting {color:red}-1 core zombie tests{color}. There are 4 zombie test(s): at org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient.testCloneLinksAfterDelete(TestCloneSnapshotFromClient.java:223) at org.apache.hadoop.hbase.client.TestReplicasClient.testScanWithReplicas(TestReplicasClient.java:600) at org.apache.hadoop.hbase.client.TestFromClientSide.testJira6912(TestFromClientSide.java:5344) at org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient.testCloneSnapshot(TestMobCloneSnapshotFromClient.java:175) at org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient.testCloneSnapshotCrossNamespace(TestMobCloneSnapshotFromClient.java:190) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15097//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15097//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15097//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15097//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15097//console This message is automatically generated. > Improve DrainBarrier > -------------------- > > Key: HBASE-14222 > URL: https://issues.apache.org/jira/browse/HBASE-14222 > Project: HBase > Issue Type: Bug > Components: util > Reporter: Hiroshi Ikeda > Assignee: Hiroshi Ikeda > Priority: Minor > Attachments: HBASE-14222.patch > > > 1. {{DrainBarrier.stopAndDrainOps}} may wait forever if > {{DrainBarrier.endOp}} changes its state and calls {{Object.notifyAll}} just > before {{stopAndDrainOps}} enters the synchronized block to call > {{Object.wait}}. Moreover, {{Object.wait}} may wake up false-positively, and > {{stopAndDrainOps}} may break the block before outstanding operations are > complete. > 2. Some tests for {{DrainBarrier}} catch and ignore {{AssertionError}} > explicitly thrown JUnit's {{fail}} method. > The implementation of {{DrainBarrier}} is a little complex, and I'll fix and > refactor it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)