[
https://issues.apache.org/jira/browse/HBASE-14249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704107#comment-14704107
]
Nick Dimiduk commented on HBASE-14249:
--------------------------------------
I applied the [attached
patch|https://issues.apache.org/jira/secure/attachment/12751368/HBASE-14249.patch]
and ran again the first command, line 57 from make_rc.sh. It doesn't appear to
have any impact on the resulting shaded artifacts. Same jars, tests no sources.
Same empty notice file in client-tests.jar.
> shaded jar modules create spurious source and test jars with incorrect
> LICENSE/NOTICE info
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-14249
> URL: https://issues.apache.org/jira/browse/HBASE-14249
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0, 1.2.0, 1.1.2, 1.3.0
> Reporter: Sean Busbey
> Attachments: HBASE-14249.patch, HBASE-14249.patch, HBASE-14249.patch,
> effective-pom.xml
>
>
> the shaded jar modules don't need to create a source or test jar (because the
> jars contain nothing other than META-INF)
> currently we create
> * the test jars are missing LICENSE
> * source jars have LICENSE/NOTICE files that claim all the bundled works in
> the normal jar.
> {code}
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-server-1.1.2-sources.jar/
> hbase-shaded-server-1.1.2-sources.jar/
> hbase-shaded-server-1.1.2-sources.jar//META-INF
> hbase-shaded-server-1.1.2-sources.jar//META-INF/LICENSE
> hbase-shaded-server-1.1.2-sources.jar//META-INF/MANIFEST.MF
> hbase-shaded-server-1.1.2-sources.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-client-1.1.2-sources.jar/
> hbase-shaded-client-1.1.2-sources.jar/
> hbase-shaded-client-1.1.2-sources.jar//META-INF
> hbase-shaded-client-1.1.2-sources.jar//META-INF/LICENSE
> hbase-shaded-client-1.1.2-sources.jar//META-INF/MANIFEST.MF
> hbase-shaded-client-1.1.2-sources.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-client-1.1.2-tests.jar/
> hbase-shaded-client-1.1.2-tests.jar/
> hbase-shaded-client-1.1.2-tests.jar//META-INF
> hbase-shaded-client-1.1.2-tests.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-server-1.1.2-tests.jar/
> hbase-shaded-server-1.1.2-tests.jar/
> hbase-shaded-server-1.1.2-tests.jar//META-INF
> hbase-shaded-server-1.1.2-tests.jar//META-INF/NOTICE
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
