[ 
https://issues.apache.org/jira/browse/HBASE-13996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705095#comment-14705095
 ] 

Andrew Purtell commented on HBASE-13996:
----------------------------------------

Thanks.

Since this a utility, it would make sense to support adjusting/overriding these 
config parameters with command line options:
{code}
+  public static final String HBASE_CANARY_WRITE_DATA_TTL_KEY = 
"hbase.canary.write.data.ttl";
+
+  public static final String 
HBASE_CANARY_WRITE_PERSERVER_REGIONS_LOWERLIMIT_KEY =
+      "hbase.canary.write.perserver.regions.lowerLimit";
+
+  public static final String 
HBASE_CANARY_WRITE_PERSERVER_REGIONS_UPPERLIMIT_KEY =
+      "hbase.canary.write.perserver.regions.upperLimit";
+
+  public static final String HBASE_CANARY_WRITE_VALUE_SIZE_KEY = 
"hbase.canary.write.value.size";
+
+  public static final String HBASE_CANARY_WRITE_TABLE_CHECK_PERIOD_KEY =
+      "hbase.canary.write.table.check.period";
{code}

Not a big deal either way.

+1 for patch v3


> Add write sniffing in canary
> ----------------------------
>
>                 Key: HBASE-13996
>                 URL: https://issues.apache.org/jira/browse/HBASE-13996
>             Project: HBase
>          Issue Type: Improvement
>          Components: canary
>    Affects Versions: 0.98.13, 1.1.0.1
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>             Fix For: 2.0.0, 1.3.0, 0.98.15
>
>         Attachments: HBASE-13996-v001.diff, HBASE-13996-v002.diff, 
> HBASE-13996-v003.diff
>
>
> Currently the canary tool only sniff the read operations, it's hard to 
> finding the problem in write path. 
> To support the write sniffing, we create a system table named '_canary_'  in 
> the canary tool. And the tool will make sure that the region number is large 
> than the number of the regionserver and the regions will be distributed onto 
> all regionservers.
> Periodically, the tool will put data to these regions to calculate the write 
> availability of HBase and send alerts if needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to