[
https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131907#comment-13131907
]
jirapos...@reviews.apache.org commented on HBASE-4510:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2108/#review2717
-----------------------------------------------------------
Ship it!
- Michael
On 2011-10-18 04:01:36, Harsh J wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2108/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-18 04:01:36)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming
refactorings were carried out.
bq.
bq. Two solutions:
bq.
bq. 1. We use new classnames. This breaks HBase's backward compatibility with
older Hadoop releases (is that a concern with future releases?)
bq. 2. HBase gets its own sets of constants as the upstream one is not marked
for public usage. This needs a little more maintenance on HBases' side.
bq.
bq. Way (2) seems more viable. I've attached an initial patch that doesn't fix
all trouble yet, but introduces the first way of changes.
bq.
bq. The remaining issue lies in the use of DistributedFileSystem's safemode
methods (which are private audience as well) inside of HBase for safemode waits
and checks (via HBases' FSUtils class). Since this uses an enum, it is more
difficult to handle without upstream interventions - thoughts?
bq.
bq.
bq. This addresses bug HBASE-4510.
bq. https://issues.apache.org/jira/browse/HBASE-4510
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java dcd0937
bq. src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 789dd3b
bq.
bq. Diff: https://reviews.apache.org/r/2108/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Harsh
bq.
bq.
> Check and workaround usage of internal HDFS APIs in HBase
> ---------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HBASE-4510.patch
>
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming
> refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with
> older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for
> public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
