[ https://issues.apache.org/jira/browse/HBASE-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709886#comment-14709886 ]
Hadoop QA commented on HBASE-13480: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12751956/HBASE-13480-2.patch against master branch at commit 9334a47d4570f8adfc003f0fb2c5969a88c3bba0. ATTACHMENT ID: 12751956 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn post-site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.TestIOFencing {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.sqoop.integration.repository.derby.upgrade.DerbyRepositoryUpgradeTest.testPostUpgrade(DerbyRepositoryUpgradeTest.java:188) at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:85) at org.testng.internal.Invoker.invokeMethod(Invoker.java:696) at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:882) at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1189) at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:124) at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108) at org.testng.TestRunner.privateRun(TestRunner.java:767) at org.testng.TestRunner.run(TestRunner.java:617) at org.testng.SuiteRunner.runTest(SuiteRunner.java:348) at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:343) at org.testng.SuiteRunner.privateRun(SuiteRunner.java:305) at org.testng.SuiteRunner.run(SuiteRunner.java:254) at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52) at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86) at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224) at org.testng.TestNG.runSuitesLocally(TestNG.java:1149) at org.testng.TestNG.run(TestNG.java:1057) at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:295) at org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:84) at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:90) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15216//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15216//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15216//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15216//console This message is automatically generated. > ShortCircuitConnection doesn't short-circuit all calls as expected > ------------------------------------------------------------------ > > Key: HBASE-13480 > URL: https://issues.apache.org/jira/browse/HBASE-13480 > Project: HBase > Issue Type: Bug > Components: Client > Affects Versions: 1.0.0, 2.0.0, 1.1.0 > Reporter: Josh Elser > Assignee: Jingcheng Du > Priority: Critical > Fix For: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.3 > > Attachments: HBASE-13480-1.patch, HBASE-13480-2.patch, > HBASE-13480.patch > > > Noticed the following situation in debugging unexpected unit tests failures > in HBASE-13351. > {{ConnectionUtils#createShortCircuitHConnection(Connection, ServerName, > AdminService.BlockingInterface, ClientService.BlockingInterface)}} is > intended to avoid the extra RPC by calling the server's instantiation of the > protobuf rpc stub directly for the AdminService and ClientService. > The problem is that this is insufficient to actually avoid extra "remote" > RPCs as all other calls to the Connection are routed to a "real" Connection > instance. As such, any object created by the "real" Connection (such as an > HTable) will use the real Connection, not the SSC. > The end result is that > {{MasterRpcService#reportRegionStateTransition(RpcController, > ReportRegionStateTransitionRequest)}} will make additional "remote" RPCs over > what it thinks is an SSC through a {{Get}} on {{HTable}} which was > constructed using the SSC, but the {{Get}} itself will use the underlying > real Connection instead of the SSC. With insufficiently sized thread pools, > this has been observed to result in RPC deadlock in the HMaster where an RPC > attempts to make another RPC but there are no more threads available to > service the second RPC so the first RPC blocks indefinitely. -- This message was sent by Atlassian JIRA (v6.3.4#6332)