[ https://issues.apache.org/jira/browse/HBASE-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711526#comment-14711526 ]
Yu Li commented on HBASE-14306: ------------------------------- And the RB link [here|https://reviews.apache.org/r/37717] > Refine RegionGroupingProvider: fix issues and make it more scalable > ------------------------------------------------------------------- > > Key: HBASE-14306 > URL: https://issues.apache.org/jira/browse/HBASE-14306 > Project: HBase > Issue Type: Improvement > Components: wal > Reporter: Yu Li > Assignee: Yu Li > Attachments: HBASE-14306.patch > > > There're multiple issues in RegionGroupingProvider, including: > * The provider cache in it is using byte array as the key of > ConcurrentHashMap, which is not right (the reason is > [here|http://stackoverflow.com/questions/1058149/using-a-byte-array-as-hashmap-key-java]) > * It's using IdentityGroupingStrategy to get group and use it as key of the > cache, which means the cache will include an entry for each region. This is > especially unnecessary when using BoundedRegionGroupingProvider > Besides fixing the above issues, I suggest to change > BoundedRegionGroupingProvider from a *provider* to a pluggable *strategy*, > which will make the whole picture much more clear. > For more details, please refer to the patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)