[ 
https://issues.apache.org/jira/browse/HBASE-14315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-14315:
----------------------------------
    Attachment: 14315-0.98.txt

Simple patch (for 0.98 for now).

The observation is simple: We already peeked the current KV, _and_ already 
checked whether it's null. We can use that in the loop and peek a new value at 
the end. It's guaranteed to save one call to peek.

Whether it's worth the slide decrease in readability is a different discussion.


> Save one call to KeyValueHeap.peek per row
> ------------------------------------------
>
>                 Key: HBASE-14315
>                 URL: https://issues.apache.org/jira/browse/HBASE-14315
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>         Attachments: 14315-0.98.txt
>
>
> Another one of my micro optimizations.
> In StoreScanner.next(...) we can actually save a call to KeyValueHeap.peek, 
> which in my runs of scan heavy loads shows up at top.
> Based on the run and data this can safe between 3 and 10% of runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to