[
https://issues.apache.org/jira/browse/HBASE-14314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715363#comment-14715363
]
Nick Dimiduk commented on HBASE-14314:
--------------------------------------
Overall looks good. Two things:
# I think we want to keep overall stats too, as primary hit rate + replica hit
rate != overall hit rate.
# some places there's a new boolean flag, other places there's a change in
method name. For instance, {{getBlockCachePrimaryHitCount()}} vs.
{{getHitCount(boolean)}}. Would be better if this was consistent one way or
there other. I think we only care about primary vs. replica (as opposed to
primary vs secondary vs tertiary), so no need for an enum. My preference is for
new method names, so we'd have {{getHitCount}}, {{getPrimaryHitCount}}, and
{{getReplicaHitCount}} for overall, primary, and replicas respectively. Could
even change {{getHitCount}} to {{getOverallHitCount}}, but that's probably not
necessary.
> Metrics for block cache should take region replicas into account
> ----------------------------------------------------------------
>
> Key: HBASE-14314
> URL: https://issues.apache.org/jira/browse/HBASE-14314
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 14314-v1.txt
>
>
> Currently metrics for block cache are aggregates in the sense that they don't
> distinguish primary from secondary / tertiary replicas.
> This JIRA separates the block cache metrics for primary region replica from
> the aggregate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
