[
https://issues.apache.org/jira/browse/HBASE-4645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133122#comment-13133122
]
jirapos...@reviews.apache.org commented on HBASE-4645:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2524/
-----------------------------------------------------------
(Updated 2011-10-21 22:14:22.830521)
Review request for Ted Yu, Michael Stack, Jonathan Gray, Lars Hofhansl,
Amitanand Aiyer, Kannan Muthukkaruppan, Karthik Ranganathan, and Nicolas
Spiegelberg.
Changes
-------
delete the middle cf.
Summary
-------
There is a data loss happening (for some of the column families) when we do the
replay logs.
The bug seems to be from the fact that during replay-logs we only choose to
replay
the logs from the maximumSequenceID across ALL the stores. This is wrong. If a
column family is ahead of others (because the crash happened before all the
column
families were flushed), then we lose data for the column families that have not
yet
caught up.
The correct logic for replay should begin the replay from the minimum across the
maximum in each store.
This addresses bug hbase-4645.
https://issues.apache.org/jira/browse/hbase-4645
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 8c32839
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
966262b
Diff: https://reviews.apache.org/r/2524/diff
Testing
-------
Initial patch. v1.
mvn test (running).
TBD: add a test case to repro the issue and make sure it fixes.
Thanks,
Amitanand
> Edits Log recovery losing data across column families
> -----------------------------------------------------
>
> Key: HBASE-4645
> URL: https://issues.apache.org/jira/browse/HBASE-4645
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.89.20100924, 0.92.0
> Reporter: Amitanand Aiyer
> Assignee: Amitanand Aiyer
>
> There is a data loss happening (for some of the column families) when we do
> the replay logs.
> The bug seems to be from the fact that during replay-logs we only choose to
> replay
> the logs from the maximumSequenceID across *ALL* the stores. This is wrong.
> If a
> column family is ahead of others (because the crash happened before all the
> column
> families were flushed), then we lose data for the column families that have
> not yet
> caught up.
> The correct logic for replay should begin the replay from the minimum across
> the
> maximum in each store.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
