[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728378#comment-14728378 ]
Hudson commented on HBASE-14229: -------------------------------- FAILURE: Integrated in HBase-0.98 #1108 (See [https://builds.apache.org/job/HBase-0.98/1108/]) HBASE-14229 Flushing canceled by coprocessor still leads to memstoreSize set down (Yerui Sun) (tedyu: rev 76243a8a93f457ccbb643ab0314e29bac5200517) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlushContext.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java > Flushing canceled by coprocessor still leads to memstoreSize set down > --------------------------------------------------------------------- > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 > Reporter: Yerui Sun > Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.1.3 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)